compare buffer bytes directly for faster detection #70
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
compare buffer bytes directly for faster detection
Previously, in order to detect the type of the file, the buffer was
converted to ASCII strings and then compared to hard-coded strings. Now,
the bytes of the buffer are compared directly to hard-coded bytes, which
is more efficient.
reduce number of benchmark cases
Previously the benchmark script ran a benchmark for each PNG file in
test/fixtures
. The measurements for all PNGs were roughly the same, sorunning a benchmark for each seems redundant. It was also time
consuming. Now, only a single PNG is benchmarked.