Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security patches #16

Merged
merged 3 commits into from
Apr 22, 2024
Merged

Security patches #16

merged 3 commits into from
Apr 22, 2024

Conversation

onepabz
Copy link
Contributor

@onepabz onepabz commented Apr 17, 2024

This pull request includes a significant update to the go.mod file, which is the Go module file for the electronwall project. The changes mainly involve updating the Go version, updating the versions of the dependencies, and adding a large number of new indirect dependencies.

Here are the most important changes:

Go version and direct dependencies updates:

  • The Go version is updated from 1.16 to 1.22, which will bring in new language features and improvements.
  • Several direct dependencies such as github.com/dop251/goja, github.com/jinzhu/configor, github.com/lightningnetwork/lnd, github.com/sirupsen/logrus, github.com/stretchr/testify, and google.golang.org/grpc have been updated to newer versions. These updates will bring in new features, improvements, and bug fixes from these libraries.

Addition of indirect dependencies:

  • A large number of indirect dependencies have been added to the require block. These are dependencies that are not directly used by your code, but are used by the direct dependencies. Adding these to the go.mod file can help ensure consistent builds by locking the versions of these indirect dependencies.

@callebtc
Copy link
Owner

Hi there, thank you for the PR. The build pipeline seems to fail, possibly might need an updated Go version as well. Would you mind trying?

Copy link
Owner

@callebtc callebtc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build works (progress!) but tests are failing now.

@onepabz onepabz requested a review from callebtc April 18, 2024 12:25
@callebtc
Copy link
Owner

Awesome work, thank you!

@callebtc callebtc merged commit 7537220 into callebtc:main Apr 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants