fix: provide original code in source maps when using RAM bundles #761
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When building RAM bundles, there are a couple issues which occur with the source map:
node_modules/@haul-bundler/core/build/webpack/loaders/babelWorkerLoader/index.js??ref--5-0!
.Setting the webpack config to use
devtool: 'source-map'
, when building RAM bundles, appears to resolve these issues.Test plan
source maps.zip, which includes source maps from the default
react-native init
Android app, both with and without this fix.For example, without the fix, the source map will contain:
/Users/jlynch/tmp/TestRNApp60/node_modules/@haul-bundler/core/build/webpack/loaders/babelWorkerLoader/index.js??ref--5-0!/Users/jlynch/tmp/TestRNApp60/App.js
With the fix, the source map will contain:
/Users/jlynch/tmp/TestRNApp60/App.js