Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: setup typescript-styled-plugin for vscode on website #136

Merged
merged 2 commits into from
Oct 18, 2017

Conversation

thymikee
Copy link
Member

Summary

This is just a proof of concept, that Linaria works with typescript-styled-plugin without additional config. Someday they'll create extensions, but until then we can use this approach.
Added a VS Code config so it's already set up if someone uses it.

@codecov
Copy link

codecov bot commented Oct 15, 2017

Codecov Report

Merging #136 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #136   +/-   ##
======================================
  Coverage    97.5%   97.5%           
======================================
  Files          19      19           
  Lines         401     401           
  Branches       74      74           
======================================
  Hits          391     391           
  Misses         10      10

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efd7ec9...7e87502. Read the comment docs.

@zamotany
Copy link
Contributor

Shouldn't .vscode folder be nested in website??

@thymikee
Copy link
Member Author

I'll check later if it works, just didn't try

@thymikee
Copy link
Member Author

Unfortunately nesting .vscode doesn't work :(

@zamotany zamotany merged commit 22657c4 into master Oct 18, 2017
@zamotany zamotany deleted the feat/ts-sc branch October 18, 2017 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants