Fix benchmark script #154
Fix benchmark script #154
Conversation
| @@ -12,17 +12,18 @@ const resultsTable = new Table({ | |||
| colWidths: [60, 10, 10], | |||
| }); | |||
|
|
|||
| const outDir = path.join(__dirname, 'suites/_temp'); | |||
| const outDir = 'benchmark/_temp'; | |||
There was a problem hiding this comment.
maybe path.join(__dirname, 'benchmark', '_temp'); ?
There was a problem hiding this comment.
outDir must be relative to CWD
Codecov Report
@@ Coverage Diff @@
## master #154 +/- ##
=======================================
Coverage 97.52% 97.52%
=======================================
Files 19 19
Lines 404 404
Branches 81 81
=======================================
Hits 394 394
Misses 10 10Continue to review full report at Codecov.
|
|
Maybe we should add a snapshot test for the benchmark.
|
|
Adding snapshot test doesn't make any sense, those are timings which changes between runs even on the same machine. Manually storing results of benchmark in JSON files and comparing it with some threshold would be a acceptable solution. If you want to ensure the benchmark is working, we can run it on Circle CI. |
Fixes #153