-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: fix website integration tests #173
Conversation
not sure why they broke, but probably because of updates to the fonts
Codecov Report
@@ Coverage Diff @@
## master #173 +/- ##
=======================================
Coverage 97.58% 97.58%
=======================================
Files 19 19
Lines 414 414
Branches 87 87
=======================================
Hits 404 404
Misses 10 10 Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #173 +/- ##
=======================================
Coverage 97.58% 97.58%
=======================================
Files 19 19
Lines 414 414
Branches 87 87
=======================================
Hits 404 404
Misses 10 10 Continue to review full report at Codecov.
|
Screenshot diff suggests that the font is no longer Montserrat, while it should be (maybe puppeteer doesn't wait for google font to download). |
Looks like Montserrat to me, but thinner. Also I didn't update puppeteer, the only thing that could change is the font which is downloaded from google fonts. |
But we use the bold one for hero... linaria/website/src/components/Hero.js Line 35 in 0fde9fd
|
All of them look thinner in the new snapshot, both body and header ones. |
Do they look like this locally? If so, I'm fine merging it. |
Yea |
not sure why they broke, but probably because of updates to the fonts