Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: fix website integration tests #173

Merged
merged 1 commit into from
Nov 10, 2017
Merged

Conversation

satya164
Copy link
Member

not sure why they broke, but probably because of updates to the fonts

not sure why they broke, but probably because of updates to the fonts
@codecov
Copy link

codecov bot commented Nov 10, 2017

Codecov Report

Merging #173 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #173   +/-   ##
=======================================
  Coverage   97.58%   97.58%           
=======================================
  Files          19       19           
  Lines         414      414           
  Branches       87       87           
=======================================
  Hits          404      404           
  Misses         10       10

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4a3806...9544071. Read the comment docs.

@codecov
Copy link

codecov bot commented Nov 10, 2017

Codecov Report

Merging #173 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #173   +/-   ##
=======================================
  Coverage   97.58%   97.58%           
=======================================
  Files          19       19           
  Lines         414      414           
  Branches       87       87           
=======================================
  Hits          404      404           
  Misses         10       10

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4a3806...9544071. Read the comment docs.

@satya164 satya164 requested a review from thymikee November 10, 2017 05:47
@thymikee
Copy link
Member

Screenshot diff suggests that the font is no longer Montserrat, while it should be (maybe puppeteer doesn't wait for google font to download).

@satya164
Copy link
Member Author

satya164 commented Nov 10, 2017

Screenshot diff suggests that the font is no longer Montserrat

Looks like Montserrat to me, but thinner.

Also I didn't update puppeteer, the only thing that could change is the font which is downloaded from google fonts.

@thymikee
Copy link
Member

But we use the bold one for hero...

font-weight: 700;
.

@satya164
Copy link
Member Author

But we use the bold one for hero

All of them look thinner in the new snapshot, both body and header ones.

@thymikee
Copy link
Member

Do they look like this locally? If so, I'm fine merging it.

@satya164
Copy link
Member Author

Yea

@zamotany zamotany merged commit 3a1ef42 into master Nov 10, 2017
@zamotany zamotany deleted the @satya164/fix-integration branch November 10, 2017 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants