Support JSON files and create dummy wrapper module for other non-JS extensions #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thymikee
reviewed
Nov 20, 2017
| try { | ||
| this.exports = JSON.parse(code); | ||
| } catch (error) { | ||
| throw new Error(`${error.message} (${filename})`); |
There was a problem hiding this comment.
If we want to be super nice, we can use https://github.com/zaach/jsonlint somewhere in the future.
Codecov Report
@@ Coverage Diff @@
## master #176 +/- ##
==========================================
+ Coverage 97.57% 97.61% +0.04%
==========================================
Files 19 19
Lines 413 420 +7
Branches 86 88 +2
==========================================
+ Hits 403 410 +7
Misses 10 10
Continue to review full report at Codecov.
|
satya164
approved these changes
Nov 20, 2017
thymikee
approved these changes
Nov 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #159