Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use project's babel config when parsing #261

Merged
merged 1 commit into from
Oct 17, 2018
Merged

Conversation

satya164
Copy link
Member

No description provided.

@callstack-bot
Copy link

callstack-bot commented Oct 17, 2018

Hey @satya164, thank you for your pull request 🤗.
The coverage report for this branch can be viewed here.

Copy link
Member

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neat

src/transform.js Outdated

const { metadata, code, map } = babel.transformSync(content, {
// Parse the code first so babel uses user's babel config for parsing
// We don't want to use user's config when trnasforming the code
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: transforming

@satya164 satya164 force-pushed the @satya164/babel-parse branch from 0a6093e to d28695f Compare October 17, 2018 11:07
@zamotany zamotany merged commit da6e3a8 into master Oct 17, 2018
@zamotany zamotany deleted the @satya164/babel-parse branch October 17, 2018 11:13
@thymikee thymikee mentioned this pull request Oct 17, 2018
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants