Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs][webpack] Use hash in CSS filename #472

Merged
merged 2 commits into from
Aug 12, 2019
Merged

[docs][webpack] Use hash in CSS filename #472

merged 2 commits into from
Aug 12, 2019

Conversation

Daniel15
Copy link
Contributor

Summary

Best practice for Webpack assets is to include a hash in the filename. This allows far future expires headers to be used, as the filename changes whenever the contents change.

Test plan
👀

@Daniel15 Daniel15 changed the title Use hash in CSS filename [docs][webpack] Use hash in CSS filename Aug 12, 2019
@callstack-bot
Copy link

callstack-bot commented Aug 12, 2019 •
edited
Loading

Hey @Daniel15, thank you for your pull request 🤗.
The coverage report for this branch can be viewed here.

thymikee
thymikee approved these changes Aug 12, 2019
View reviewed changes
Copy link
Member

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@thymikee thymikee merged commit 4acde48 into callstack:master Aug 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thymikee thymikee thymikee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Daniel15 @callstack-bot @thymikee