feat: upgraded corejs to v3 #525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @alicanerdogan, thank you for your pull request 🤗. |
satya164
reviewed
Jan 11, 2020
| @@ -407,7 +407,7 @@ CSS: | |||
| ; | |||
| } | |||
|
|
|||
| Dependencies: core-js/modules/es6.string.raw | |||
| Dependencies: core-js/modules/es.array.map, core-js/modules/es.array.slice, core-js/modules/es.string.raw | |||
There was a problem hiding this comment.
We should prolly add es.array.map and es.array.slice to the exclude option in babel config.
There was a problem hiding this comment.
You are certainly right, I added those two to the exclude list
Anber
approved these changes
Jan 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
linaria has a core dependency of corejs v2, however corejs v2 is deprecated and it is not supported anymore. To keep up with the other working environment which are up to date, corejs version has been updated to v3 with this plan.
Here is the issue link: #420
Test plan
The PR successfully passes all the tests within repo and it is locally tested to check it's sanity.