Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document how to use Linaria with Svelte #593

Merged
merged 1 commit into from
Jun 16, 2020

Conversation

madhavarshney
Copy link
Contributor

@madhavarshney madhavarshney commented May 1, 2020

Motivation

Document how to use Linaria with Svelte. Resolves #435.

Summary

N/A

Test plan

N/A

@madhavarshney madhavarshney changed the title Document how to use linaria with Svelte Document how to use Linaria with Svelte May 1, 2020
@callstack-bot
Copy link

callstack-bot commented May 1, 2020

Hey @madhavarshney, thank you for your pull request 🤗.
The coverage report for this branch can be viewed here.


#### Rollup

Take a look: [d964432](https://github.com/madhavarshney/svelte-linaria-sample/commit/d96443218694c0c8d80edf7c40a8fbf7c1f6997f)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you like to create a separate examples folder / repo and instead link this there? This may also help for #590.

Copy link
Contributor

@jayu jayu May 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a great idea! If we have docs on integrations in one place we can also have examples in our repo, especially if the example does not exist in specific tools repository (eg. next.js has an example with linaria).

Would it be possible to have one example for svelte but with two bundlers set-up?
If not, I'm ok with the following structure
/examples/svelte/rollup
/examples/svelte/webpack

But for any other examples, I believe there will be possible to have one code base with two bundlers or there will be only one bundler if framework assumes usage of a specific one

@Tsubasa1218 Tsubasa1218 mentioned this pull request May 2, 2020
@jayu
Copy link
Contributor

jayu commented Jun 16, 2020

@madhavarshney I'm merging it as it is. If you decide to add svelte example just open another PR. Thanks for the input!

@jayu jayu merged commit 2cbad09 into callstack:master Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Svelte.
3 participants