Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update preact configuration #631

Merged
merged 1 commit into from
Aug 10, 2020
Merged

Conversation

tamorim
Copy link
Contributor

@tamorim tamorim commented Jun 19, 2020

Motivation

Easier setup of linaria with preact when coming from a preact-cli generated boilerplate.

#590

Test plan

Generate a new project using the preact-cli and follow the updated steps and ensure that's working as intended.

@callstack-bot
Copy link

callstack-bot commented Jun 19, 2020

Hey @tamorim, thank you for your pull request 🤗.
The coverage report for this branch can be viewed here.

@jayu
Copy link
Contributor

jayu commented Jun 22, 2020

Thanks for the PR @tamorim !
Can you please also upgrade the config in out preact example https://github.com/callstack/linaria/tree/master/examples/Preact/preact-example ?

Thanks to that we will be able to verify if the change works!

Makes setting up linaria with preact easier when coming from a preact-cli generated boilerplate.
@tamorim
Copy link
Contributor Author

tamorim commented Jun 22, 2020

@jayu Sorry for missing the example 😅
Just pushed the new changes, thanks for the direction!

@Anber Anber merged commit 260b60c into callstack:master Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants