Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(webpack): fix usage of webpackResolveOptions conditionally #883

Merged
merged 2 commits into from
Dec 15, 2021
Merged

fix(webpack): fix usage of webpackResolveOptions conditionally #883

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d0cd16
fix(webpack): fix usage of webpackResolveOptions conditionally
jpnelson Dec 11, 2021
d503e9d
fix(webpack): fix usage of webpackResolveOptions in webpack5-loader too
jpnelson Dec 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/webpack4-loader/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ export default function webpack4Loader(

// Resolved configuration contains empty list of extensions as a default value
// https://github.com/callstack/linaria/issues/855
if (webpackResolveOptions.extensions?.length === 0) {
if (webpackResolveOptions?.extensions?.length === 0) {
delete webpackResolveOptions.extensions;
}

Expand Down
2 changes: 1 addition & 1 deletion packages/webpack5-loader/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ export default function webpack5Loader(

// Resolved configuration contains empty list of extensions as a default value
// https://github.com/callstack/linaria/issues/855
if (webpackResolveOptions.extensions?.length === 0) {
if (webpackResolveOptions?.extensions?.length === 0) {
delete webpackResolveOptions.extensions;
}

Expand Down