-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Podspec not published to npm if the package name contains hyphens #39
Comments
satya164
added a commit
that referenced
this issue
Dec 16, 2020
When using `<%= code %>` in `ejs`, it escapes characters by default. This is useful when writing HTML, but in our case, it may sometimes lead to undesirable behavior. For example, if you generate a project with the description "Satya's cool library", it would escape `'` and output: "Satya' cool library". This commit swaps the templates to use `<%- code %>` so that nothing is escaped.
satya164
added a commit
that referenced
this issue
Dec 16, 2020
d53d8f6 When using `<%= code %>` in `ejs`, it escapes characters by default. This is useful when writing HTML, but in our case, it may sometimes lead to undesirable behavior. For example, if you generate a project with the description "Satya's cool library", it would escape `'` and output: "Satya' cool library". This commit swaps the templates to use `<%- code %>` so that nothing is escaped.
satya164
added a commit
that referenced
this issue
Dec 16, 2020
When using `<%= code %>` in `ejs`, it escapes characters by default. This is useful when writing HTML, but in our case, it may sometimes lead to undesirable behavior. For example, if you generate a project with the description "Satya's cool library", it would escape `'` and output: "Satya' cool library". This commit swaps the templates to use `<%- code %>` so that nothing is escaped.
satya164
added a commit
that referenced
this issue
Dec 16, 2020
When using `<%= code %>` in `ejs`, it escapes characters by default. This is useful when writing HTML, but in our case, it may sometimes lead to undesirable behavior. For example, if you generate a project with the description "Satya's cool library", it would escape `'` and output: "Satya' cool library". This commit swaps the templates to use `<%- code %>` so that nothing is escaped.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bug
The
files
array generated bypackage.json
removes any hyphens from the name of the generated podspec, and thus won't publish the podspec when publishing a package whose name includes hyphens to npm.For a project named
react-native-safe-popover
, thepackage.json
'sfiles
array comes out as:The podspec, meanwhile, is named
react-native-safe-popover.podspec
.Environment info
react-native info
output:Library version:
0.10.0
Steps To Reproduce
npx @react-native-community/bob create react-native-safe-popover cd react-native-safe-popover yarn bootstrap
Describe what you expected to happen:
Either of these two:
react-native-safe-popover.podspec
AND thefiles
array inpackage.json
should includereact-native-safe-popover.podspec
.reactnativesafepopover.podspec
AND thefiles
array inpackage.json
should includereactnativesafepopover.podspec
.Option 1 would be preferable, as it preserves the package name.
Reproducible sample code
See "Steps To Reproduce".
The text was updated successfully, but these errors were encountered: