feat: add fabric option #273

troZee · 2022-09-06T13:26:55Z

Summary

Close #238

Test plan

troZee · 2022-09-06T13:34:08Z

packages/create-react-native-library/src/index.ts

-  type?: 'module-legacy' | 'module-turbo' | 'module-mixed' | 'view' | 'library';
+  type?:
+    | 'module-legacy'
+    | 'module-new-arch'


@satya164 , I changed 'xxx-turbo' => 'xxx-new-arch' to avoid any confusion.
Fabric will refer to view, turbomodule will refer to module. Since the fact fabric is a new renderer, I would like to use new-arch postfix for the new arch

packages/create-react-native-library/src/index.ts

troZee · 2022-09-06T13:38:49Z

packages/create-react-native-library/templates/common/$package.json

    "@types/jest": "^28.1.2",
    "@types/react": "~17.0.21",
-    "@types/react-native": "0.68.0",
+    "@types/react-native": <%-/* TODO: bump version of rn to 0.69.0 */ project.newArchitecture ? '"0.69.5"':'"0.68.0"'-%>,


Will adjust this todo after merge #271

troZee · 2022-09-06T13:39:57Z

...es/create-react-native-library/templates/example/example/android/app/src/main/jni/Android.mk

-<% if (project.turbomodule) { -%>
-  libreact_codegen_<%- project.name -%> \
+<% if (project.newArchitecture) { -%>
+  libreact_codegen_<%- project.view ? project.name+'View': project.name -%> \


It will not be needed in RN 70

...native-library/templates/example/example/android/app/src/main/jni/MainComponentsRegistry.cpp

...ary/templates/java-view-mixed-library/android/src/legacy/{%- project.name %}ViewManager.java

…emplate # Conflicts: # packages/create-react-native-library/templates/example-legacy/example/$.bundle/config # packages/create-react-native-library/templates/example-legacy/example/$.ruby-version # packages/create-react-native-library/templates/example-legacy/example/$package.json # packages/create-react-native-library/templates/example-legacy/example/$yarn.lock # packages/create-react-native-library/templates/example-legacy/example/Gemfile # packages/create-react-native-library/templates/example-legacy/example/Gemfile.lock # packages/create-react-native-library/templates/example-legacy/example/android/app/build.gradle # packages/create-react-native-library/templates/example-legacy/example/android/app/debug.keystore # packages/create-react-native-library/templates/example-legacy/example/android/app/proguard-rules.pro # packages/create-react-native-library/templates/example-legacy/example/android/app/src/debug/AndroidManifest.xml # packages/create-react-native-library/templates/example-legacy/example/android/app/src/debug/java/com/example/{%- project.package %}/ReactNativeFlipper.java # packages/create-react-native-library/templates/example-legacy/example/android/app/src/main/AndroidManifest.xml # packages/create-react-native-library/templates/example-legacy/example/android/app/src/main/java/com/example/{%- project.package %}/MainActivity.java # packages/create-react-native-library/templates/example-legacy/example/android/app/src/main/java/com/example/{%- project.package %}/MainApplication.java # packages/create-react-native-library/templates/example-legacy/example/android/app/src/main/java/com/example/{%- project.package %}/newarchitecture/MainApplicationReactNativeHost.java # packages/create-react-native-library/templates/example-legacy/example/android/app/src/main/java/com/example/{%- project.package %}/newarchitecture/components/MainComponentsRegistry.java # packages/create-react-native-library/templates/example-legacy/example/android/app/src/main/java/com/example/{%- project.package %}/newarchitecture/modules/MainApplicationTurboModuleManagerDelegate.java # packages/create-react-native-library/templates/example-legacy/example/android/app/src/main/jni/Android.mk # packages/create-react-native-library/templates/example-legacy/example/android/app/src/main/jni/MainApplicationModuleProvider.cpp # packages/create-react-native-library/templates/example-legacy/example/android/app/src/main/jni/MainApplicationModuleProvider.h # packages/create-react-native-library/templates/example-legacy/example/android/app/src/main/jni/MainApplicationTurboModuleManagerDelegate.cpp # packages/create-react-native-library/templates/example-legacy/example/android/app/src/main/jni/MainApplicationTurboModuleManagerDelegate.h # packages/create-react-native-library/templates/example-legacy/example/android/app/src/main/jni/MainComponentsRegistry.cpp # packages/create-react-native-library/templates/example-legacy/example/android/app/src/main/jni/MainComponentsRegistry.h # packages/create-react-native-library/templates/example-legacy/example/android/app/src/main/jni/OnLoad.cpp # packages/create-react-native-library/templates/example-legacy/example/android/app/src/main/res/drawable/rn_edit_text_material.xml # packages/create-react-native-library/templates/example-legacy/example/android/app/src/main/res/mipmap-hdpi/ic_launcher.png # packages/create-react-native-library/templates/example-legacy/example/android/app/src/main/res/mipmap-hdpi/ic_launcher_round.png # packages/create-react-native-library/templates/example-legacy/example/android/app/src/main/res/mipmap-mdpi/ic_launcher.png # packages/create-react-native-library/templates/example-legacy/example/android/app/src/main/res/mipmap-mdpi/ic_launcher_round.png # packages/create-react-native-library/templates/example-legacy/example/android/app/src/main/res/mipmap-xhdpi/ic_launcher.png # packages/create-react-native-library/templates/example-legacy/example/android/app/src/main/res/mipmap-xhdpi/ic_launcher_round.png # packages/create-react-native-library/templates/example-legacy/example/android/app/src/main/res/mipmap-xxhdpi/ic_launcher.png # packages/create-react-native-library/templates/example-legacy/example/android/app/src/main/res/mipmap-xxhdpi/ic_launcher_round.png # packages/create-react-native-library/templates/example-legacy/example/android/app/src/main/res/mipmap-xxxhdpi/ic_launcher.png # packages/create-react-native-library/templates/example-legacy/example/android/app/src/main/res/mipmap-xxxhdpi/ic_launcher_round.png # packages/create-react-native-library/templates/example-legacy/example/android/app/src/main/res/values/strings.xml # packages/create-react-native-library/templates/example-legacy/example/android/app/src/main/res/values/styles.xml # packages/create-react-native-library/templates/example-legacy/example/android/build.gradle # packages/create-react-native-library/templates/example-legacy/example/android/gradle.properties # packages/create-react-native-library/templates/example-legacy/example/android/gradle/wrapper/gradle-wrapper.jar # packages/create-react-native-library/templates/example-legacy/example/android/gradle/wrapper/gradle-wrapper.properties # packages/create-react-native-library/templates/example-legacy/example/android/gradlew # packages/create-react-native-library/templates/example-legacy/example/android/gradlew.bat # packages/create-react-native-library/templates/example-legacy/example/android/settings.gradle # packages/create-react-native-library/templates/example-legacy/example/index.ts # packages/create-react-native-library/templates/example-legacy/example/index.tsx # packages/create-react-native-library/templates/example-legacy/example/ios/Podfile # packages/create-react-native-library/templates/example-legacy/example/ios/{%- project.name %}Example.xcodeproj/project.pbxproj # packages/create-react-native-library/templates/example-legacy/example/ios/{%- project.name %}Example.xcodeproj/xcshareddata/xcschemes/{%- project.name %}Example.xcscheme # packages/create-react-native-library/templates/example-legacy/example/ios/{%- project.name %}Example.xcworkspace/contents.xcworkspacedata # packages/create-react-native-library/templates/example-legacy/example/ios/{%- project.name %}Example.xcworkspace/xcshareddata/IDEWorkspaceChecks.plist # packages/create-react-native-library/templates/example-legacy/example/ios/{%- project.name %}Example/AppDelegate.h # packages/create-react-native-library/templates/example-legacy/example/ios/{%- project.name %}Example/AppDelegate.mm # packages/create-react-native-library/templates/example-legacy/example/ios/{%- project.name %}Example/Images.xcassets/AppIcon.appiconset/Contents.json # packages/create-react-native-library/templates/example-legacy/example/ios/{%- project.name %}Example/Images.xcassets/Contents.json # packages/create-react-native-library/templates/example-legacy/example/ios/{%- project.name %}Example/Info.plist # packages/create-react-native-library/templates/example-legacy/example/ios/{%- project.name %}Example/LaunchScreen.storyboard # packages/create-react-native-library/templates/example-legacy/example/ios/{%- project.name %}Example/main.m # packages/create-react-native-library/templates/example-new/example/patches/react-native+0.68.2.patch # packages/create-react-native-library/templates/example-new/example/patches/react-native+0.70.0.patch

atlj · 2022-09-09T09:08:00Z

There is an issue

Issue

 ./create-react-native-library test      ✘ PIPE 5s
✔ What is the name of the npm package? … react-native-test
✔ What is the description for the package? … sdf
✔ What is the name of package author? … Burak
✔ What is the email address for the package author? … burak.guner@callstack.com
✔ What is the URL for the package author? … https://
✔ What is the URL for the repository? … https://
✔ What type of library do you want to develop? › Native fabric view with backward compat (experimental)
create-react-native-library <name>

create a react native library

Options:
  --help          Show help                                            [boolean]
  --version       Show version number                                  [boolean]
  --slug          Name of the npm package                               [string]
  --description   Description of the npm package                        [string]
  --author-name   Name of the package author                            [string]
  --author-email  Email address of the package author                   [string]
  --author-url    URL for the package author                            [string]
  --repo-url      URL for the repository                                [string]
  --languages     Languages you want to use
      [choices: "java-objc", "java-swift", "kotlin-objc", "kotlin-swift", "cpp",
                                                                           "js"]
  --type          Type of library you want to develop[choices: "module", "view"]
  --example       Type of example app                [choices: "expo", "native"]

[Error: ENOENT: no such file or directory, scandir '/Users/burakguner/kod/react-native-builder-bob/packages/create-react-native-library/templates/java-view-mixed-library'] {
  errno: -2,
  code: 'ENOENT',
  syscall: 'scandir',
  path: '/Users/burakguner/kod/react-native-builder-bob/packages/create-react-native-library/templates/java-view-mixed-library'
}

Steps to reproduce

run create-react-native-library
choose Native fabric view with backward compat (experimental) for What type of library do you want to develop?

packages/create-react-native-library/src/index.ts

packages/create-react-native-library/templates/common/$package.json

# Conflicts: # packages/create-react-native-library/src/index.ts # packages/create-react-native-library/templates/common/$package.json # packages/create-react-native-library/templates/example-legacy/example/index.js # packages/create-react-native-library/templates/example-legacy/example/react-native.config.js # packages/create-react-native-library/templates/example/example/react-native.config.js # packages/create-react-native-library/templates/java-library-new/android/src/main/java/com/{%- project.package %}/{%- project.name %}Module.java # packages/create-react-native-library/templates/java-library-new/android/src/main/java/com/{%- project.package %}/{%- project.name %}Package.java # packages/create-react-native-library/templates/java-library-new/android/src/main/java/com/{%- project.package_dir %}/{%- project.name %}Module.java # packages/create-react-native-library/templates/java-library-new/android/src/main/java/com/{%- project.package_dir %}/{%- project.name %}Package.java # packages/create-react-native-library/templates/java-library-turbo/android/src/main/java/com/{%- project.package %}/{%- project.name %}Package.java # packages/create-react-native-library/templates/java-view-legacy/android/src/main/java/com/{%- project.package %}/{%- project.name %}Package.java # packages/create-react-native-library/templates/java-view-legacy/android/src/main/java/com/{%- project.package %}/{%- project.name %}ViewManager.java # packages/create-react-native-library/templates/java-view-legacy/android/src/main/java/com/{%- project.package_dir %}/{%- project.name %}Package.java # packages/create-react-native-library/templates/java-view-legacy/android/src/main/java/com/{%- project.package_dir %}/{%- project.name %}ViewManager.java # packages/create-react-native-library/templates/java-view-library/android/src/main/java/com/{%- project.package %}/{%- project.name %}Package.java # packages/create-react-native-library/templates/kotlin-view-legacy/android/src/main/java/com/{%- project.package %}/{%- project.name %}Package.kt # packages/create-react-native-library/templates/kotlin-view-legacy/android/src/main/java/com/{%- project.package %}/{%- project.name %}ViewManager.kt # packages/create-react-native-library/templates/kotlin-view-legacy/android/src/main/java/com/{%- project.package_dir %}/{%- project.name %}Package.kt # packages/create-react-native-library/templates/kotlin-view-legacy/android/src/main/java/com/{%- project.package_dir %}/{%- project.name %}ViewManager.kt # packages/create-react-native-library/templates/kotlin-view-library/android/src/main/java/com/{%- project.package %}/{%- project.name %}ViewManager.kt # packages/create-react-native-library/templates/native-common/example/react-native.config.js

troZee · 2022-10-24T13:57:32Z

@satya164 @atlj @MateWW
PR is ready for testing

packages/create-react-native-library/src/index.ts

packages/create-react-native-library/templates/common/CONTRIBUTING.md

satya164 · 2022-10-24T18:21:17Z

packages/create-react-native-library/templates/common/README.md

 const result = await multiply(3, 7);
 ```
+
 <% } -%>


Avoid adding new lines here

packages/create-react-native-library/templates/objc-view-mixed/ios/{%- project.name %}View.mm

.../create-react-native-library/templates/objc-view-mixed/ios/{%- project.name %}ViewManager.mm

.github/workflows/build-templates.yml

- Fix eslint issues - move hexStringColor to Utils

migueldaipre · 2022-10-27T16:47:36Z

@satya164 Any news when this will be released?

thymikee · 2022-10-27T17:53:01Z

🔜

MateWW and others added 21 commits August 25, 2022 22:16

feat: initial fabric cli

8e8e114

feat: fabric root directory

d5aec16

feat: fabric src dir

dbde595

feat: fabric ios dir

677b08b

feat: generate example app via react-native init

9f1febf

chore(example template): remove android files

a06282b

chore(example template): remove unused root files

3d2482f

chore(example template): remove ios files

98f8e40

chore(example template): remove android buildscripts

795d980

refactor: move rn example app generator to utils

93223d1

feat: tbc

d7fa53f

chore(example template): rename index.tsx to index.ts

25bb21b

feat: enable new architecture on turbo module libraries

8bd1521

feat: rename to new_arch

1e3c167

refactor: rename app exampleAppGenerators to generateRNApp

e1aacb6

refactor: don't specify RN version for example apps

910769d

refactor(example generator): extract files to delete to constant

8d3e444

refactor(rn example generator): extract packages to add and remove

3e1548b

fix: native example code is generated on expo projects

2f01afb

fix: example

a112c16

fix: MainComponentsRegistry headers

a0390ea

troZee requested review from MateWW and satya164 September 6, 2022 13:27

troZee commented Sep 6, 2022

View reviewed changes

troZee requested a review from atlj September 6, 2022 13:34

troZee commented Sep 6, 2022

View reviewed changes

packages/create-react-native-library/src/index.ts Outdated Show resolved Hide resolved

troZee commented Sep 6, 2022

View reviewed changes

...native-library/templates/example/example/android/app/src/main/jni/MainComponentsRegistry.cpp Outdated Show resolved Hide resolved

troZee commented Sep 6, 2022

View reviewed changes

...ary/templates/java-view-mixed-library/android/src/legacy/{%- project.name %}ViewManager.java Outdated Show resolved Hide resolved

troZee marked this pull request as ready for review September 8, 2022 15:39

atlj reviewed Sep 9, 2022

View reviewed changes

packages/create-react-native-library/src/index.ts Outdated Show resolved Hide resolved

atlj mentioned this pull request Sep 9, 2022

chore: add new github workflow to test every template #276

Merged

6 tasks

Piotr Trocki added 4 commits September 13, 2022 10:34

fix: java view mixed path

6d19ea5

fix: App.tsx template

bc926bc

chore: bump react native version

dbfaf38

fix: App.tsx new arch

bdb6dce

troZee commented Sep 14, 2022

View reviewed changes

packages/create-react-native-library/templates/common/$package.json Outdated Show resolved Hide resolved

chore: bump @types/react-native to 0.70.0

8ac7b5d

satya164 mentioned this pull request Oct 13, 2022

Where do we stand with Turbomodules? #247

Closed

satya164 force-pushed the main branch 2 times, most recently from b94e81b to cf3f675 Compare October 18, 2022 21:31

Piotr Trocki added 2 commits October 24, 2022 14:35

remove patch-package

a066c22

troZee requested review from MateWW and atlj October 24, 2022 13:57

troZee commented Oct 24, 2022

View reviewed changes

packages/create-react-native-library/src/index.ts Outdated Show resolved Hide resolved

add fix flag

1daacea

satya164 reviewed Oct 24, 2022

View reviewed changes

troZee commented Oct 25, 2022

View reviewed changes

.github/workflows/build-templates.yml Outdated Show resolved Hide resolved

- Remove commands

59d628c

- Fix eslint issues - move hexStringColor to Utils

troZee requested a review from satya164 October 25, 2022 10:24

satya164 merged commit c43878f into main Oct 27, 2022

satya164 deleted the MateWW/fabric-template branch October 27, 2022 15:35

okwasniewski pushed a commit that referenced this pull request Nov 4, 2022

feat: add fabric template (#273)

dfa20a4

feat: add fabric option #273

feat: add fabric option #273

Uh oh!

Conversation

troZee commented Sep 6, 2022

Summary

Test plan

Uh oh!

troZee Sep 6, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

troZee Sep 6, 2022

Choose a reason for hiding this comment

Uh oh!

troZee Sep 6, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

atlj commented Sep 9, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue

Steps to reproduce

Uh oh!

Uh oh!

Uh oh!

troZee commented Oct 24, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

satya164 Oct 24, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

migueldaipre commented Oct 27, 2022

Uh oh!

thymikee commented Oct 27, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

atlj commented Sep 9, 2022 •

edited

Loading

troZee commented Oct 24, 2022 •

edited

Loading