Skip to content

Conversation

atlj
Copy link
Collaborator

@atlj atlj commented Sep 8, 2022

Summary

With this GitHub workflow, we are now available to run yarn lint, yarn test, and yarn typescript on every possible example app

Test plan

  • Turbo module with backward compat (experimental)
  • Turbo module (experimental)
  • Native module
  • Native view
  • JavaScript library
  • Expo app

Future Plans

We might also test if the app builds for ios and android in the future.

@atlj atlj requested review from MateWW, satya164 and troZee and removed request for satya164 September 8, 2022 15:37
include:
- language: js
example: expo
type: module
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Supper minor thing but maybe we can keep one order of those keys.

Copy link
Collaborator Author

@atlj atlj Sep 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, what is your preferred order I think
type
language
example

would be nice, I will also refactor the order I give these arguments

Copy link
Contributor

@MateWW MateWW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@atlj atlj closed this Sep 9, 2022
@atlj
Copy link
Collaborator Author

atlj commented Sep 9, 2022

This was closed because we created #276 with a new branch located from this repo instead of a fork

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants