feat: handle theme change based on preferences #2016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The mobile version of example app from this branch is ready! You can see it here |
satya164
reviewed
Jun 26, 2020
src/core/Provider.tsx
Outdated
| } else { | ||
| const theme = | ||
| this.state.colorScheme === 'light' ? DefaultTheme : DarkTheme; | ||
| return Object.assign(theme as ReactNativePaper.Theme, { |
There was a problem hiding this comment.
Probably not from your change, but Object.assign incorrect here since:
- It'll mutate our theme
- Adding
animationproperty will override anything else defined in this property. We don't have anything else right now, but might have in future.
satya164
reviewed
Jun 26, 2020
troZee
force-pushed
the
feat/dark-light-theme
branch
3 times, most recently
from
36791a5 to
de8c2ec
Compare
|
|
matkoson
approved these changes
Jun 29, 2020
satya164
reviewed
Jun 29, 2020
troZee
force-pushed
the
feat/dark-light-theme
branch
from
a627ee3 to
58ab6a0
Compare
Trancever
approved these changes
Jun 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #1597
Android 10 and iOS 13 added support for dark theme. User (like me ;p) can set dark theme as default theme. Application should adapt to this theme automatically, hence I would like to have automatically theme changing in my app, so I don't need to care about user preferences.
TODO
Screenshots
Test plan