Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: handle theme change based on preferences #1780

Closed
wants to merge 1 commit into from

Conversation

troZee
Copy link
Member

@troZee troZee commented Apr 3, 2020

Motivation

Closes #1597

Android 10 and iOS 13 added support for dark theme. User (like me ;p) can set dark theme as default theme. Application should adapt to this theme automatically, hence I would like to have automatically theme changing in my app, so I don't need to care about user preferences. This is only a draft, because RNP needs to be bumped to 0.62. Example will be add later, once expo adds support to 0.62.

Test plan

@callstack-bot
Copy link

Hey @troZee, thank you for your pull request 🤗. The documentation from this branch can be viewed here.

@Trancever
Copy link
Contributor

@troZee There are CI checks failing but besides that the PR looks really good 🔥

@troZee
Copy link
Member Author

troZee commented Apr 3, 2020

@troZee There are CI checks failing but besides that the PR looks really good 🔥

Should I bump RN version to 0.62 in this PR ? Or should I wait for RNP with rn 0.62 ?

@github-actions
Copy link

github-actions bot commented Jun 8, 2020

Hello 👋, this pull request has been open for more than 2 months with no activity on it. If you think this is still necessary with the latest version, please comment and ping a maintainer to get this reviewed, otherwise it will be closed automatically in 7 days.

@github-actions github-actions bot added the Stale label Jun 8, 2020
@troZee troZee added enhancement and removed Stale labels Jun 8, 2020
@troZee
Copy link
Member Author

troZee commented Jun 26, 2020

Closed in favor of #2016

@troZee troZee closed this Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set dark or light theme according to device preferences by default
3 participants