Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING: TextInput redesign #429

Closed

Conversation

gawrysiak
Copy link
Collaborator

@gawrysiak gawrysiak commented Jun 21, 2018

TextInput redesign - work in progress

So far:

screen shot 2018-06-21 at 23 25 13

TODO

Fixes #359.

@callstack-bot
Copy link

callstack-bot commented Jun 21, 2018

Hey @gawrysiak, thank you for your pull request 🤗. The documentation from this branch can be viewed here.

@fzyzcjy
Copy link
Contributor

fzyzcjy commented Jul 20, 2018

Hello! May I ask when will this be merged? I think it is wonderful!

@gawrysiak
Copy link
Collaborator Author

@Turtlegood hey, it's still missing the leading & trailing icon features and some polishing. I'll try to figure it out through the weekend

@fzyzcjy
Copy link
Contributor

fzyzcjy commented Jul 20, 2018

@gawrysiak wow thanks!

@gawrysiak gawrysiak changed the title WIP: BREAKING: TextInput redesign BREAKING: TextInput redesign Jul 22, 2018
@gawrysiak gawrysiak removed the wip label Jul 22, 2018
@gawrysiak
Copy link
Collaborator Author

@satya164 this one wasn't so easy for me with all the features included and my first try on animations. Took ages, sometimes feels hacky, I'm also unsure about some of the behaviours (like outlined + leading icon). Please review carefully

@henrymoulton
Copy link

Hey guys just want to say I'm a big fan of React Native Paper... any update when this planning on being merged?

@gawrysiak
Copy link
Collaborator Author

Hi @henrymoulton
There's not so much left to complete 2.0. You should be able to see the details here and the RTL task was recently merged. Also, @ferrannp will be soon introducing Paper 2.0 at React Native EU which makes it not so much time left to finish it. While it might be not so possible to give a date on particular tasks, React Native EU is less than 4 weeks away. Hope this works for you.

@henrymoulton
Copy link

@gawrysiak thanks Grzegorz for this and looking forward to the release 💯

@satya164
Copy link
Member

I'm reviewing it. There are visual issues on Android, so it'll take some changes before merging.

@satya164
Copy link
Member

Closing in favor of #522

@satya164 satya164 closed this Aug 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants