feat: new method getBottomTabHeight
added to BottomNavigationBar
#4408
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Our app requires a feature "Scroll to show/hide BottomTabs" same as LinkedIn Bottom Tabs feature. Implementing this feature was not a problem, however to achieve this animation, we need the Height of the BottomTabs.
This height is retrieved from
useBottomTabBarHeight();
. But it does not calculate the height correctly on Android when we use CustomtabBar
withcreateBottomTabNavigator
from'@react-navigation/bottom-tabs'
Goal
To get the correct height of the rendered Bottom tabs when its using
react-native-paper
Related issue
Currently, the
BottomNavigationBar
does not provide a way to get the height of the renderedBottomNavigationBar
.When using the
useBottomTabBarHeight()
it gives the height of the default bottom tabs from@react-navigation/bottom-tabs
Test plan
Please note that the
zustand
global store was used to store this bottom tab height, but can easily replicate with local state as well.Example usage