Fix accessibility-related crash on Android 4.x (#220).

[MarkCSmith]

Avoid calling isAccessibilityFocused() on Android < Lollipop.

Summary:

Fixes issue #220.

Test Plan:

We reproduced a crash on an Android 4.1 emulator, applied this patch, and observed that the crash no longer occurred.

[michalchudziak]

Hey @MarkCSmith ! Thank you for this PR.

I wonder if removing a call of this.setupAccessibility(); at all on Android < Lollipop is the way to go. You claim that calling isAccessibilityFocused() is crashing an app. Perhaps we should omit just this call on these Android versions and just rely on event.getEventType() == AccessibilityEvent.TYPE_VIEW_SELECTED? Perhaps it'd resolve the crash and maintain this.setupAccessibility(); call?

Any thoughts?

[MarkCSmith]

Hey @MarkCSmith ! Thank you for this PR.

I wonder if removing a call of this.setupAccessibility(); at all on Android < Lollipop is the way to go. You claim that calling isAccessibilityFocused() is crashing an app. Perhaps we should omit just this call on these Android versions and just rely on event.getEventType() == AccessibilityEvent.TYPE_VIEW_SELECTED? Perhaps it'd resolve the crash and maintain this.setupAccessibility(); call?

I think that approach would be fine. However, my understanding is that React Native 0.64.x drops support for Android 4.x. Maybe in that case it is no longer important to fix this issue. What do you think?

[BartoszKlonowski]

In my opinion it is always worth to support all versions, no matter if they are supported on newer RN releases.
@MarkCSmith It would be great if you could rebase your branch so the conflicts are gone and we can revisit the fix.

[BartoszKlonowski]

Thank you, @MarkCSmith!

[BartoszKlonowski]

I allowed myself to rebase your changes @MarkCSmith and I adjusted them to the latest of setupAccessibility method.

[MarkCSmith]

Thank you @BartoszKlonowski !