Skip to content

Fix: can't drag to the end of track on iOS #334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 18, 2021
Merged

Fix: can't drag to the end of track on iOS #334

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
69dc771
Check if targeted value exceeds the range
BartoszKlonowski Oct 18, 2021
ca9a7ed
Cover the check with comment explaining its purpose
BartoszKlonowski Oct 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/ios/RNCSliderManager.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,9 +77,14 @@ - (void)tapHandler:(UITapGestureRecognizer *)gesture {
}

static float discreteValue(RNCSlider *sender, float value) {
// Check if thumb should reach the maximum value and put it on the end of track if yes.
// To avoid affecting the thumb when on maximum, the `step >= (value - maximum)` is not checked.
if (sender.step > 0 && value >= sender.maximumValue) {
return sender.maximumValue;
}

// If step is set and less than or equal to difference between max and min values,
// pick the closest discrete multiple of step to return.

if (sender.step > 0 && sender.step <= (sender.maximumValue - sender.minimumValue)) {

// Round up when increase, round down when decrease.
Expand Down