Skip to content

Fix: Type error when using Slider with props as ref #369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 20, 2022
Merged

Fix: Type error when using Slider with props as ref #369

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1852034
Introduce SliderReferenceType
BartoszKlonowski Apr 14, 2022
e52d678
Use SliderReferenceType for ref type
BartoszKlonowski Apr 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/typings/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,11 @@
import * as React from "react";
import * as ReactNative from "react-native";

type SliderReferenceType = (
React.MutableRefObject<SliderRef> &
React.LegacyRef<Slider>
) | undefined;

export interface SliderPropsAndroid extends ReactNative.ViewProps {
/**
* Color of the foreground switch grip.
Expand Down Expand Up @@ -145,7 +150,7 @@ export interface SliderProps extends SliderPropsIOS, SliderPropsAndroid, SliderP
/**
* Reference object.
*/
ref?: React.MutableRefObject<SliderRef>;
ref?: SliderReferenceType;
}

/**
Expand Down