Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing header guard #592

Merged

Conversation

alanjhughes
Copy link
Contributor

Summary:

When compiling for the new architecture the build fails on android because of a missing header guard in RNCSliderMeasurementsManager.h

Test Plan:

Issue can be reproduced in the example app in the repo. Adding the guard compiles successfully.

Copy link
Member

@BartoszKlonowski BartoszKlonowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@@ -1,4 +1,6 @@
#ifdef ANDROID
#pragma once
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yes! That's mine mistake - I got confused #ifdef with ifndef and suggested removing once during review of new arch measurement PR #589. 🙇‍♂️

@BartoszKlonowski BartoszKlonowski merged commit fc9b5ee into callstack:main Apr 12, 2024
8 checks passed
This was referenced Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants