fix: support for react native 0.81 on Android #722
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
gabrieldonadel
added a commit
to expo/expo
that referenced
this pull request
Aug 6, 2025
# Why We should bump @react-native-community/slider to the latest version for SDK 54 (waiting for callstack/react-native-slider#722 to be released in order to remove our patch) # How Update @react-native-community/slider to 5.0.0 # Test Plan - BareExpo - ExpoGo # Checklist <!-- Please check the appropriate items below if they apply to your diff. --> - [ ] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
okwasniewski
approved these changes
Aug 7, 2025
BartoszKlonowski
approved these changes
Aug 7, 2025
|
Can we merge this before the 0.81 release? |
|
@BartoszKlonowski can you release a new version with this fix? 🙏 |
|
Hi, we currently can't upgrade to RN 0.81 because of this issue. Is there an estimate for a new release with this fix? |
3 tasks
gabrieldonadel
added a commit
to expo/expo
that referenced
this pull request
Aug 19, 2025
# Why callstack/react-native-slider#722 just got released fixing support for 0.81, and we can now remove our patch # How Update @react-native-community/slider to 5.0.1 # Test Plan - BareExpo - ExpoGo # Checklist <!-- Please check the appropriate items below if they apply to your diff. --> - [ ] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
Eric-Tyrrell22
pushed a commit
to Eric-Tyrrell22/expo
that referenced
this pull request
Sep 5, 2025
# Why callstack/react-native-slider#722 just got released fixing support for 0.81, and we can now remove our patch # How Update @react-native-community/slider to 5.0.1 # Test Plan - BareExpo - ExpoGo # Checklist <!-- Please check the appropriate items below if they apply to your diff. --> - [ ] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Trying to use
react-native-sliderwith react-native 0.81.0-rc.5 will cause an insta crash in the app due to an issue when parsingRNCSliderPropson AndroidThese changes are related to the Props 2.0 project and require us to set the necessary flags and definitions in Cmake, by using
target_compile_reactnative_optionsthis can be done automatically instead of setting them manually.Test Plan:
npx @react-native-community/cli@latest init RC5 --skip-install --version nextyarn add @react-native-community/sliderpackage/android/src/main/jni/CMakeLists.txt