Add support for ByRole with name #1127
Merged
+112
−15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Folllow up of #875. I started from scratch given the amount of conflicts.
Closes #827
If merged as is, don't forget to mention @kiranjd as part of the release.
Kudo to @MattAgn's work in #977 which made that a breeze. Look at the diff between this PR and the previously opened one, the code reorg was def the right call.