chore: deprecate some a11y queries #1226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdjastrzebski
changed the title
mdjastrzebski
force-pushed
the
feat/deprecate-some-a11y-queries
branch
from
4fae1c7
to
2078fa5
Compare
mdjastrzebski
requested review from
MattAgn,
AugustinLF and
pierrezimmermannbam
and removed request for
MattAgn and
AugustinLF
mdjastrzebski
changed the title
src/queries/a11yState.ts
Outdated
| getByAccessibilityState: getByA11yState, | ||
| getAllByAccessibilityState: getAllByA11yState, | ||
| queryByAccessibilityState: queryByA11yState, | ||
| queryAllByAccessibilityState: queryAllByA11yState, | ||
| findByAccessibilityState: findByA11yState, | ||
| findAllByAccessibilityState: findAllByA11yState, | ||
| }, | ||
| 'AccessibilityState', | ||
| 'Role(role, { disabled, selected, checked, busy, expanded }) query or expect(...).toHaveAccessibilityState(...) matcher' | ||
| 'Use {queryPrefix}ByRole(role, { disabled, selected, checked, busy, expanded }) query or expect(...).toHaveAccessibilityState(...) matcher instead.' |
There was a problem hiding this comment.
Great refactor !
pierrezimmermannbam
approved these changes
Jan 27, 2023
thymikee
reviewed
Jan 27, 2023
AugustinLF
requested changes
Jan 27, 2023
thymikee
approved these changes
Jan 27, 2023
AugustinLF
requested changes
Jan 27, 2023
Codecov ReportBase: 95.98% // Head: 96.04% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1226 +/- ##
==========================================
+ Coverage 95.98% 96.04% +0.06%
==========================================
Files 47 49 +2
Lines 3240 3290 +50
Branches 489 494 +5
==========================================
+ Hits 3110 3160 +50
Misses 130 130
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Make
*ByA11yStateand*ByA11yValuequeries deprecated, redirecting user to use*ByRolequeries ortoHaveAcessbibilityState/Value()matchers.When doing any of the mentioned queries, user will received following warning to console:
Resolves #1208
Test plan
Add tests for deprecation messages warnings.