Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update docs on custom jest preset #1316

Merged
merged 4 commits into from
Feb 17, 2023

Conversation

pierrezimmermannbam
Copy link
Collaborator

Summary

Based on #1307

Updates docs to specify that jest preset is no longer required for users that have a version of react native >= 0.71.2

Test plan

README.md Outdated Show resolved Hide resolved
website/docs/API.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Member

@mdjastrzebski mdjastrzebski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest re-ordering of our preset info to mention RN version application first, this will allow users on RN 0.71+ to quickly establish that they do not need to use it.

README.md Outdated Show resolved Hide resolved
pierrezimmermann and others added 3 commits February 17, 2023 13:45
Co-authored-by: Maciej Jastrzebski <mdjastrzebski@gmail.com>
Co-authored-by: Maciej Jastrzebski <mdjastrzebski@gmail.com>
@codecov
Copy link

codecov bot commented Feb 17, 2023

Codecov Report

Base: 96.07% // Head: 96.09% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (9659108) compared to base (1e8b3ba).
Patch has no changes to coverable lines.

❗ Current head 9659108 differs from pull request most recent head 37ff2c4. Consider uploading reports for the commit 37ff2c4 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1316      +/-   ##
==========================================
+ Coverage   96.07%   96.09%   +0.02%     
==========================================
  Files          49       49              
  Lines        3308     3333      +25     
  Branches      497      503       +6     
==========================================
+ Hits         3178     3203      +25     
  Misses        130      130              
Impacted Files Coverage Δ
src/screen.ts 100.00% <0.00%> (ø)
src/render.tsx 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants