docs: add missing assignment in render.mdx #1649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1649 +/- ##
==========================================
- Coverage 95.51% 95.46% -0.06%
==========================================
Files 99 101 +2
Lines 5400 5508 +108
Branches 857 880 +23
==========================================
+ Hits 5158 5258 +100
- Misses 242 250 +8 ☔ View full report in Codecov by Sentry. |
Comment on lines
13
to
16
| import { render } from '@testing-library/react-native'; | ||
|
|
||
| test('basic test', () => { | ||
| render(<MyApp />); | ||
| const screen = render(<MyApp />); |
There was a problem hiding this comment.
Instead of capturing render output we recommend using screen object exported by RNTL, so rather than update this line, we should add screen to the import above.
mdjastrzebski
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I believe there is a missing assignment in the docs.
Test plan