Finish refactoring queries using new query builder makeQueries #654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@thymikee @mdjastrzebski I modified a bit the error messages to unify them with the errors messages for byTestId which were modified on the previous PR, is it ok for you? |
MattAgn
force-pushed
the
refactor/build-queries-for-all
branch
from
c8c59b8
to
9198eb3
Compare
|
I did not tackle the UNSAFE and a11y queries (since they have their own builder already), is it alright? |
MattAgn
force-pushed
the
refactor/build-queries-for-all
branch
from
9198eb3
to
0895b3f
Compare
the renaming is done to avoid any confusion with makeQueries which should be the new way to add new queries
thymikee
force-pushed
the
refactor/build-queries-for-all
branch
from
0895b3f
to
8628435
Compare
|
thanks for the approval @thymikee! Should I group the tests by query in a new PR now? Because for now it is done for only one query (byTestId) and not the others |
|
Sure, would be amazing to have the tests cleaned up as well :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR aims to solve this issue. It is the follow up of this PR
Tasks:
type (different for get, find, query).
Requirements
Test plan
No tests should be added since the API does not change, they only need to be moved to be grouped by predicate type