-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hover style API: variable border radius #69
Comments
@gokul1099 Created an issue for the feature you was working on |
@okwasniewski looks like PR #66 is broken and not working now. Can you check once. |
@okwasniewski while working for PR #66 I made all the changes in RCTViewComponentView file and it works. But after recent commits any changes in RCTViewComponentView is not reflecting. I even added breakpoint and it's not working. |
@gokul1099 Can you try installing pods with RCT_NEW_ARCH_ENABLED=1 flag? Recently in core they changed that RNTester is not building with new arch by default |
oh ok, let me try |
I tried this still not working |
@gokul1099 Another change I missed upstream is that we are now running Bridgeless mode by default. This PR fixes hoverStyle for bridgeless mode: #92, so you should be now able to see your breakpoints |
@okwasniewski I don't think this is specific to hoverStyle prop. Currently none of the methods in the RCTViewComponentView is being invoked. |
This feature has been tackled by @Saadnajmi in this PR: facebook#43078 - which will be soon cherry-picked to react-native-visionos |
fixed by: #114 |
Description
The goal of this issue is to adapt hoverStyle API to properly use variable corner radius for each corner of the view. This is a continuation of the work done in #66
The text was updated successfully, but these errors were encountered: