Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable remove outliers by default #560

Merged
merged 5 commits into from
Mar 11, 2025

Conversation

mdjastrzebski
Copy link
Member

@mdjastrzebski mdjastrzebski commented Mar 7, 2025

Summary

Scope:

  • enable outlier removal by defaults
  • rename dropOutliers to removeOutliers

Test plan

@mdjastrzebski mdjastrzebski force-pushed the feat/enable-drop-outliers branch from c888d7d to f5f3f1e Compare March 10, 2025 13:35
Copy link
Contributor

github-actions bot commented Mar 10, 2025

Performance Comparison Report

  • Current: HEAD (bc9f683) - 2025-03-11 08:35:03Z
  • Baseline: main (4d7071c) - 2025-03-11 08:34:23Z

Significant Changes To Duration

Show entries
Name Type Duration Count
InitialRenders 1 render 1.1 ms → 0.8 ms (-0.3 ms, -28.3%) 🟢 2 → 2
Show details
Name Type Duration Count
InitialRenders 1 render Baseline
Mean: 1.1 ms
Stdev: 0.2 ms (17.9%)
Runs: 1.2 1.3 1.2 1.5 1.2 1.0 1.1 0.9 0.9 0.8
Warmup runs: 1663.1
Removed outliers: (none)

Current
Mean: 0.8 ms
Stdev: 0.0 ms (3.2%)
Runs: 0.8 0.8 0.8 0.8 0.8 0.8 0.8 0.8 0.8 0.8
Warmup runs: 10.4
Removed outliers: (none)
Baseline
Mean: 2
Stdev: 0 (0.0%)
Runs: 2 2 2 2 2 2 2 2 2 2
Render issues:
- Initial updates: 1

Current
Mean: 2
Stdev: 0 (0.0%)
Runs: 2 2 2 2 2 2 2 2 2 2
Render issues:
- Initial updates: 1

Meaningless Changes To Duration

Show entries
Name Type Duration Count
`fib` function fib(30) function 39.1 ms → 39.2 ms (+0.1 ms, ±0.0%) 1 → 1
`fib` function fib(30) async async function 39.2 ms → 39.2 ms (+0.0 ms, ±0.0%) 1 → 1
`fib` function fib(31) function 63.8 ms → 63.3 ms (-0.4 ms, -0.7%) 1 → 1
`fib` function fib(31) async async function 63.4 ms → 63.3 ms (-0.1 ms, ±0.0%) 1 → 1
`fib` function fib(32) function 102.6 ms → 102.5 ms (-0.0 ms, ±0.0%) 1 → 1
`fib` function fib(32) async async function 102.8 ms → 102.3 ms (-0.5 ms, ±0.0%) 1 → 1
<AsyncComponent />: 10 runs render 49.9 ms → 50.3 ms (+0.4 ms, +0.8%) 4 → 4
<AsyncComponent />: 20 runs render 50.4 ms → 50.3 ms (-0.1 ms, ±0.0%) 4 → 4
Async Component render 82.4 ms → 82.5 ms (+0.1 ms, ±0.0%) 7 → 7
InitialRenders 3 render 1.1 ms → 1.2 ms (+0.0 ms, +1.6%) 4 → 4
ManyRenderIssues render 1.3 ms → 1.3 ms (-0.0 ms, -0.5%) 5 → 5
RedundantUpdates render 0.8 ms → 0.8 ms (-0.0 ms, -3.2%) 2 → 2
Show details
Name Type Duration Count
`fib` function fib(30) function Baseline
Mean: 39.1 ms
Stdev: 0.1 ms (0.3%)
Runs: 39.1 39.1 39.1 39.0 39.0 39.0 39.3 39.0 39.2 39.0
Warmup runs: 35.8
Removed outliers: (none)

Current
Mean: 39.2 ms
Stdev: 0.1 ms (0.2%)
Runs: 39.2 39.2 39.3 39.2 39.2 39.2 39.1 39.1 39.4 39.2
Warmup runs: 39.6
Removed outliers: (none)
Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
`fib` function fib(30) async async function Baseline
Mean: 39.2 ms
Stdev: 0.2 ms (0.4%)
Runs: 38.7 39.2 39.1 39.4 39.1 39.1 39.2 39.3 39.2 39.2
Warmup runs: 38.7
Removed outliers: (none)

Current
Mean: 39.2 ms
Stdev: 0.1 ms (0.2%)
Runs: 39.1 39.1 39.2 39.3 39.2 39.2 39.1 39.1
Warmup runs: 38.7
Removed outliers: 38.6 42.0
Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
`fib` function fib(31) function Baseline
Mean: 63.8 ms
Stdev: 0.8 ms (1.3%)
Runs: 64.3 63.9 65.7 63.7 62.9 63.4 63.3 63.3 63.3
Warmup runs: 64.0
Removed outliers: 71.2

Current
Mean: 63.3 ms
Stdev: 0.1 ms (0.1%)
Runs: 63.4 63.3 63.4 63.1 63.3 63.3 63.4 63.4 63.4
Warmup runs: 62.8
Removed outliers: 63.0
Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
`fib` function fib(31) async async function Baseline
Mean: 63.4 ms
Stdev: 0.0 ms (0.1%)
Runs: 63.3 63.4 63.4 63.4 63.5 63.4 63.4 63.4 63.4
Warmup runs: 63.2
Removed outliers: 58.6

Current
Mean: 63.3 ms
Stdev: 0.2 ms (0.3%)
Runs: 63.3 63.4 63.3 63.7 63.5 63.3 63.3 63.4 63.0 63.3
Warmup runs: 62.6
Removed outliers: (none)
Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
`fib` function fib(32) function Baseline
Mean: 102.6 ms
Stdev: 0.1 ms (0.1%)
Runs: 102.6 102.5 102.6 102.5 102.5 102.6 102.5 102.5 102.8
Warmup runs: 104.7
Removed outliers: 97.5

Current
Mean: 102.5 ms
Stdev: 0.1 ms (0.1%)
Runs: 102.6 102.4 102.5 102.5 102.7 102.7 102.4 102.6 102.5 102.5
Warmup runs: 101.5
Removed outliers: (none)
Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
`fib` function fib(32) async async function Baseline
Mean: 102.8 ms
Stdev: 1.5 ms (1.4%)
Runs: 101.4 103.3 101.4 101.5 102.2 105.2 102.5 102.6 105.5 102.6
Warmup runs: 101.4
Removed outliers: (none)

Current
Mean: 102.3 ms
Stdev: 0.4 ms (0.4%)
Runs: 101.3 102.5 102.4 102.5 102.5 102.6 102.4 102.6 102.4
Warmup runs: 101.3
Removed outliers: 105.4
Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
<AsyncComponent />: 10 runs render Baseline
Mean: 49.9 ms
Stdev: 0.3 ms (0.7%)
Runs: 49.6 49.9 49.8 50.1 50.0 50.3 50.5 49.5 49.8 49.7
Warmup runs: 66.8
Removed outliers: (none)

Current
Mean: 50.3 ms
Stdev: 2.1 ms (4.1%)
Runs: 49.0 50.4 56.0 50.3 49.5 48.9 49.9 50.0 49.3 49.7
Warmup runs: 133.8
Removed outliers: (none)
Baseline
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4
Render issues:
- Initial updates: 1

Current
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4
Render issues:
- Initial updates: 1
<AsyncComponent />: 20 runs render Baseline
Mean: 50.4 ms
Stdev: 0.8 ms (1.5%)
Runs: 50.1 52.1 50.5 50.7 50.3 51.1 51.0 50.9 50.7 51.1 50.9 50.2 50.1 50.6 50.1 50.5 49.6 50.0 49.1 48.5
Warmup runs: 50.7
Removed outliers: (none)

Current
Mean: 50.3 ms
Stdev: 0.2 ms (0.4%)
Runs: 50.3 50.3 50.4 50.4 50.9 50.1 50.6 50.4 50.5 50.4 50.1 50.1 50.1 50.2 50.3 50.2 50.2 50.2 50.4 50.2
Warmup runs: 50.8
Removed outliers: (none)
Baseline
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4
Render issues:
- Initial updates: 1

Current
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4
Render issues:
- Initial updates: 1
Async Component render Baseline
Mean: 82.4 ms
Stdev: 1.5 ms (1.8%)
Runs: 80.7 81.2 82.3 81.5 85.7 81.6 82.3 84.1 82.3 82.6
Warmup runs: 91.0
Removed outliers: (none)

Current
Mean: 82.5 ms
Stdev: 1.2 ms (1.4%)
Runs: 81.6 82.9 83.3 82.7 83.5 84.6 81.9 80.5 83.0 81.5
Warmup runs: 89.9
Removed outliers: (none)
Baseline
Mean: 7
Stdev: 0 (0.0%)
Runs: 7 7 7 7 7 7 7 7 7 7
Render issues:
- Initial updates: 1

Current
Mean: 7
Stdev: 0 (0.0%)
Runs: 7 7 7 7 7 7 7 7 7 7
Render issues:
- Initial updates: 1
InitialRenders 3 render Baseline
Mean: 1.1 ms
Stdev: 0.0 ms (1.9%)
Runs: 1.2 1.2 1.2 1.2 1.2 1.1 1.1 1.1 1.2 1.1
Warmup runs: 1.3
Removed outliers: (none)

Current
Mean: 1.2 ms
Stdev: 0.1 ms (6.9%)
Runs: 1.1 1.2 1.2 1.4 1.1 1.1 1.2 1.1 1.1 1.1
Warmup runs: 1.1
Removed outliers: (none)
Baseline
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4
Render issues:
- Initial updates: 3

Current
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4
Render issues:
- Initial updates: 3
ManyRenderIssues render Baseline
Mean: 1.3 ms
Stdev: 0.0 ms (2.7%)
Runs: 1.3 1.3 1.4 1.3 1.3 1.3 1.3 1.3 1.3 1.3
Warmup runs: 1.4
Removed outliers: (none)

Current
Mean: 1.3 ms
Stdev: 0.0 ms (2.4%)
Runs: 1.3 1.3 1.3 1.3 1.3 1.4 1.3 1.3 1.3 1.4
Warmup runs: 1.3
Removed outliers: (none)
Baseline
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5
Render issues:
- Initial updates: 2
- Redundant updates: 2 (3, 4)

Current
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5
Render issues:
- Initial updates: 2
- Redundant updates: 2 (3, 4)
RedundantUpdates render Baseline
Mean: 0.8 ms
Stdev: 0.1 ms (9.5%)
Runs: 1.0 0.8 0.8 0.8 0.8 0.8 0.8 0.8 0.8 0.8
Warmup runs: 0.9
Removed outliers: (none)

Current
Mean: 0.8 ms
Stdev: 0.1 ms (6.9%)
Runs: 0.8 0.8 0.8 0.8 0.8 0.7 0.8 0.8 0.9 0.8
Warmup runs: 0.8
Removed outliers: (none)
Baseline
Mean: 2
Stdev: 0 (0.0%)
Runs: 2 2 2 2 2 2 2 2 2 2
Render issues:
- Redundant updates: 1 (1)

Current
Mean: 2
Stdev: 0 (0.0%)
Runs: 2 2 2 2 2 2 2 2 2 2
Render issues:
- Redundant updates: 1 (1)

Render Count Changes

There are no entries

Render Issues

Name Initial Updates Redundant Updates
<AsyncComponent />: 10 runs 1 🔴 -
<AsyncComponent />: 20 runs 1 🔴 -
InitialRenders 1 1 🔴 -
InitialRenders 3 3 🔴 -
RedundantUpdates - 1 (1) 🔴
ManyRenderIssues 2 🔴 2 (3, 4) 🔴
Async Component 1 🔴 -

Added Entries

There are no entries

Removed Entries

There are no entries

Generated by 🚫 dangerJS against 7ed0120

@mdjastrzebski mdjastrzebski changed the title feat: enable drop outliers by default feat: enable remove outliers by default Mar 11, 2025
@mdjastrzebski mdjastrzebski merged commit b34459f into main Mar 11, 2025
4 checks passed
@mdjastrzebski mdjastrzebski deleted the feat/enable-drop-outliers branch March 11, 2025 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant