Skip to content

Conversation

shubhamguptadream11
Copy link
Contributor

@shubhamguptadream11 shubhamguptadream11 commented Oct 28, 2024

Adding activeIndicator prop in android.

This props is working with Material Design 3.

Screenshot_20241028_163815

@okwasniewski
Copy link
Collaborator

Thanks for working on this! Can you also add implementation for new architecture? Just merged #79 🙏

Will do a release after this PR lands

@shubhamguptadream11
Copy link
Contributor Author

@okwasniewski Thanks for sharing the screenshot here showing the activeIndicator color in use. I'm attempting to implement a similar solution on the Android side by setting itemActiveIndicatorColor = color, but I'm not seeing any effect in my example component.

Could you confirm if setting itemActiveIndicatorColor alone was sufficient in your setup, or were additional steps needed?

@okwasniewski
Copy link
Collaborator

@shubhamguptadream11 Can you show me a screenshot? Maybe you are using Material2 component styles?

You can find info about styling here: https://okwasniewski.github.io/react-native-bottom-tabs/docs/guides/android-native-styling.html

@okwasniewski
Copy link
Collaborator

Checked out your branch and it's working!

CleanShot 2024-10-28 at 11 33 37@2x

@shubhamguptadream11
Copy link
Contributor Author

Screenshot_20241028_160936
Here is the snap. I am checking in example of native bottom tabs repo.

@okwasniewski
Copy link
Collaborator

@shubhamguptadream11 I think this doesn't have any effect on Material2 component design only on Material3

@shubhamguptadream11
Copy link
Contributor Author

@okwasniewski Yeah this might be the case.

@shubhamguptadream11 shubhamguptadream11 marked this pull request as ready for review October 28, 2024 10:50
Copy link
Collaborator

@okwasniewski okwasniewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this!

Everything looks good, can you add this to prop to docs?

@shubhamguptadream11
Copy link
Contributor Author

@okwasniewski updated the doc. Should we also mention it's compatibility with material 3?
Like this

activeIndicatorColor <Badge text="android" type="info" />
Sets the color of the tab indicator. This option is only compatible with Material3 themes

@okwasniewski
Copy link
Collaborator

@okwasniewski updated the doc. Should we also mention it's compatibility with material 3? Like this

activeIndicatorColor <Badge text="android" type="info" />
Sets the color of the tab indicator. This option is only compatible with Material3 themes

Yeah, let's add it

Copy link
Collaborator

@okwasniewski okwasniewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@okwasniewski okwasniewski merged commit 30add00 into callstackincubator:main Oct 28, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants