-
Notifications
You must be signed in to change notification settings - Fork 69
Added activeIndicator color in android #83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added activeIndicator color in android #83
Conversation
Thanks for working on this! Can you also add implementation for new architecture? Just merged #79 🙏 Will do a release after this PR lands |
@okwasniewski Thanks for sharing the screenshot here showing the activeIndicator color in use. I'm attempting to implement a similar solution on the Android side by setting Could you confirm if setting |
@shubhamguptadream11 Can you show me a screenshot? Maybe you are using Material2 component styles? You can find info about styling here: https://okwasniewski.github.io/react-native-bottom-tabs/docs/guides/android-native-styling.html |
@shubhamguptadream11 I think this doesn't have any effect on Material2 component design only on Material3 |
@okwasniewski Yeah this might be the case. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this!
Everything looks good, can you add this to prop to docs?
@okwasniewski updated the doc. Should we also mention it's compatibility with material 3?
|
Yeah, let's add it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Adding
activeIndicator
prop in android.This props is working with
Material Design 3
.