Skip to content

Conversation

@LukasMod
Copy link

@LukasMod LukasMod commented Nov 12, 2025

Summary

Adds ACL (Access Control List) configuration support to the S3 provider, allowing users to set object-level permissions for uploaded artifacts.

Test Plan

Unit tests that verifies:

  • ACL: 'public-read' is included in upload params when acl is configured
  • no default settings (current tests cover that)

Note

Adds optional acl to S3 provider config and forwards it to upload requests, with tests and docs updated.

  • Provider S3:
    • Add acl?: clientS3.ObjectCannedACL to ProviderConfig in packages/provider-s3/src/lib/providerS3.ts and README.
    • Pass ACL to S3 Upload params when acl is configured.
  • Tests:
    • Add unit test verifying ACL is included in upload params when acl is set.
  • Docs:
    • Update packages/provider-s3/README.md and website/src/docs/configuration.md S3 options to document acl and allowed values.

Written by Cursor Bugbot for commit acc5e94. This will update automatically on new commits. Configure here.

@vercel
Copy link

vercel bot commented Nov 12, 2025

@LukasMod is attempting to deploy a commit to the Callstack Team on Vercel.

A member of the Team first needs to authorize it.

@LukasMod LukasMod changed the title feat: Add ACL config for providerS3 feat: add ACL config for providerS3 Nov 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant