-
Notifications
You must be signed in to change notification settings - Fork 22
chore: ease commands discovery #130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: ease commands discovery #130
Conversation
|
@dprevost-LMI is attempting to deploy a commit to the Callstack Team on Vercel. A member of the Team first needs to authorize it. |
|
The GitHub UI is crashing because of the number of changes included 🙈 |
|
Yes, beside the below:
|
|
Let's name the aliases after the commands they run - typecheck and lint. For Prettier, let's use format instead (it doesn't necessarily have to be Prettier every time). |
2df2d12 to
c66248e
Compare
|
Here you go: "scripts": {
"prepare": "husky",
"typecheck": "pnpm nx run-many -t typecheck --projects='packages/*'",
"lint": "pnpm nx run-many -t lint --projects='packages/*'",
"format": "prettier --check .",
"format:fix": "prettier --check . --write",
"check": "pnpm typecheck && pnpm lint && pnpm format"
}, |
c66248e to
538093e
Compare
|
Rebased and prettier --fix rerun, so ready again! |
|
@V3RON, this week or next, I'll revert all prod code changes and keep only the script changes in the package.json, making it easier to review and merge. |
- Add script to run easier tsc and linting commands - Test command was not added since there is not test to run - Add a command running all of them in one shoot
362cb34 to
1c2d96c
Compare
|
Here the PR without auto-fix |
|
You have run out of free Bugbot PR reviews for this billing cycle. This will reset on December 2. To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial. |
|
I went ahead and renamed a few commands and added some Prettier exclusions (native code, lockfile, and Markdown). |
Have tsc and linting commands more self-discoverable
Inspired by the CONTRIBUTING.md
Note
Adds repo-wide typecheck/lint/format scripts, updates
.prettierignoreglobs, and upgrades Prettier to v3 with lockfile changes.typecheck,lint,format,format:fix, andchecksscripts inpackage.json.prettierfrom^2.6.2to^3.6.2and updatepnpm-lock.yaml..prettierignoreto use**/distand**/coveragepatterns.Written by Cursor Bugbot for commit f108fa9. This will update automatically on new commits. Configure here.