Skip to content
This repository has been archived by the owner on May 2, 2023. It is now read-only.

Should use "strict mode" #14

Open
calmh opened this issue Jan 3, 2016 · 0 comments
Open

Should use "strict mode" #14

calmh opened this issue Jan 3, 2016 · 0 comments
Labels
enhancement

Comments

@calmh
Copy link
Owner

calmh commented Jan 3, 2016 

#!/bin/bash
set -euo pipefail
IFS=$'\n\t'

(IFS then needs various values along the way)
troyjfarrell added a commit to troyjfarrell/smartos-platform-upgrade that referenced this issue Feb 7, 2017
@troyjfarrell
Exit immediately on non-zero status from pipelines
84999ca 
Prior to this change, the script allowed for silent failures of pipelines.
This change uses the set -e command to alter that default behavior.

This change also ignores a non-zero status when unmount is called to unmount
the USB device's first partition.  Testing showed that the umount command
returned a non-zero status on every execution because the partition was not
mounted.  Prior to this change, the same non-zero status was being ignored.

Related: calmh#14
@robinbowes robinbowes mentioned this issue May 18, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Major refactor - strict mode and functions robinbowes/smartos-platform-upgrade
1 participant
@calmh