Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trino support #114

Closed
damian3031 opened this issue Oct 26, 2023 · 0 comments · Fixed by #115
Closed

Trino support #114

damian3031 opened this issue Oct 26, 2023 · 0 comments · Fixed by #115

Comments

@damian3031
Copy link
Contributor

I would be awesome if we could add Trino support to dbt-date.

Currently, we maintain a separate package called dbt-trino-utils containing Trino-specific macro implementations.
However, as this package continues to grow with new additions, it introduces certain challenges.
Some of these packages have different dbt-core version requirements, which force us to use a lower version
for one of the packages.

It would be more efficient to directly add Trino implementations for a few macros into dbt-date
rather than replicating the entire test suite on our side.

Furthermore, this approach offers a more user-friendly experience as users won't need to install an additional package and make extra configurations in their dbt_project.yml file.

Regarding testing, we can set up a Docker container with a Trino image in CI and run tests on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant