Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Trino support #115

Merged
merged 2 commits into from
Nov 2, 2023
Merged

Add Trino support #115

merged 2 commits into from
Nov 2, 2023

Conversation

damian3031
Copy link
Contributor

resolves #114

I'm not sure if I've set up CircleCI properly, as I'm not familiar with it. Your assistance would be greatly appreciated 🙂

@clausherther
Copy link
Contributor

Thanks! Let me look over this over the weekend and think about whether we want to get into supporting Trino in our repo.

@clausherther clausherther mentioned this pull request Oct 27, 2023
Closed
@clausherther
Copy link
Contributor

FYI, CI is failing on the docker container https://app.circleci.com/pipelines/github/calogica/dbt-date/138/workflows/ae42adc3-3f8f-4733-8bfa-a3e181cc2901/jobs/151/parallel-runs/0/steps/0-106

In my experience, debugging CircleCI or any CI is a major pain which is why that's been the biggest blocker for adding new platform support.

@clausherther
Copy link
Contributor

@damian3031 CI still erroring out
https://app.circleci.com/pipelines/github/calogica/dbt-date/139/workflows/d624876c-ff97-43c3-92e2-70b5724d13a8/jobs/157/parallel-runs/0/steps/0-107

@damian3031
Copy link
Contributor Author

@clausherther I've set up CircleCI in my fork and made sure that the CI is passing. There shouldn't be any errors now.

clausherther
clausherther approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@clausherther clausherther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@clausherther
Copy link
Contributor

Looks good. I think you need a rebase to resolve those conflicts and then we're good to go!

@clausherther
Copy link
Contributor

Looks good. I think you need a rebase to resolve those conflicts and then we're good to go!

nm, looks like you did already ;)

@clausherther clausherther merged commit ed92294 into calogica:main Nov 2, 2023
5 checks passed
@damian3031
Copy link
Contributor Author

Awesome! Thanks for releasing it quickly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clausherther clausherther clausherther approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Trino support
2 participants
@damian3031 @clausherther