Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update testing structure for dbt Labs testing support - postgres #132

Closed
wants to merge 2 commits into from

Conversation

emmyoop
Copy link

@emmyoop emmyoop commented Oct 11, 2024

Resolves #131

This only adds support for testing with postgres. Postgres is run inside the GitHub runner and I do not need to worry about getting credentials for the various warehouses set up this way.

To add additional adapter testing support in the future, you will just need to modify

  • .github/workflows/ci.yml to pass through the env vars
  • modify profiles.yml to meet the desire var format (example in dbt-package-testing)
  • supported_adapters.env to list the adapters you want to test
  • tox.ini to add the commands for the adapter tests

I have also left all CircleCi testing in place for now so you can verify that the new testing format is equivalent. If you choose, you can remove CircleCI testing completely once all adapters are setup with the new tox method.

Why Do We Need These Changes

As explained in #131, by setting up tox as a standard entry-point, the Core development team at dbt Labs can include this package's integration tests (along with other popular dbt packages) as part of our continuous development & delivery of dbt.

@emmyoop emmyoop changed the title add setup for dbt run testing via tox Update testing structure for dbt Labs testing support Oct 11, 2024
@emmyoop emmyoop changed the title Update testing structure for dbt Labs testing support Update testing structure for dbt Labs testing support - postgres Oct 11, 2024
@clausherther
Copy link
Contributor

FYI, closing this since we'll be stopping support for this package by the end of year.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants