Fix timezone conversion macro on redshift #63
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there! First of all, thank you for building/maintaining this package, I am using it and it rocks.
When calling a calendar date macro (in my case
dbt_date.today()
on redshift with dbt 1.0.0, I received the following error:I looked into it and basically it seems that the default implementation you had for the timezone conversion is the supported way in redshift, but dbt's dispatch was calling the postgres implementation per its search ordering, but the postgres implementation does not work in redshift.
I consulted the dbt docs to see the best way to handle this and they recommend implementing a redshift dispatch which simply calls the default implementation in cases like this (bottom of page) which seemed reasonable to me. Hence this PR! And thanks again for the package 😄