Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace hardcoded transform in expect_column_to_exist #118

Conversation

UselessAlias
Copy link
Contributor

Replaced hardcoded value with mapping call to provided transform filter and join to reduce list back to single value.

Replaced hardcoded value with mapping call to provided transform filter and join to reduce list back to single value.
@clausherther clausherther linked an issue Oct 15, 2021 that may be closed by this pull request
@clausherther clausherther self-requested a review October 15, 2021 18:31
@clausherther clausherther changed the title Fixed bug Replace hardcoded transform in expect_column_to_exist Oct 15, 2021
Copy link
Contributor

@clausherther clausherther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@clausherther clausherther merged commit 1db8720 into calogica:main Oct 15, 2021
@clausherther
Copy link
Contributor

I'll cut a new release this weekend unless there are other PRs close to being done to roll in as well.

@UselessAlias UselessAlias deleted the bug/hardcoded_value_blocks_functionality_expect_column_to_exist branch October 18, 2021 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hardcode value in expect_column_to_exist.sql prevent functionality
2 participants