Added partition by in lag tests #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @Lucasthenoob! Will look over this over the weekend. |
clausherther
requested changes
Feb 26, 2022
There was a problem hiding this comment.
Couple of changes re: partition column parameters.
Also, we'll need a test that actually uses these partitions in https://github.com/calogica/dbt-expectations/blob/main/integration_tests/models/schema_tests/schema.yml
I can help you with that if you've never done integration tests on dbt packages. Thanks!
macros/schema_tests/column_values_basic/expect_column_values_to_be_decreasing.sql
Outdated
Show resolved
Hide resolved
macros/schema_tests/column_values_basic/expect_column_values_to_be_decreasing.sql
Outdated
Show resolved
Hide resolved
macros/schema_tests/column_values_basic/expect_column_values_to_be_increasing.sql
Outdated
Show resolved
Hide resolved
|
It should be good now. |
clausherther
approved these changes
Mar 4, 2022
clausherther
added a commit
that referenced
this pull request
Apr 4, 2022
…y_n_datepart` (#141) * implement exclusion_condition (#1) * move exclusion_condition to closing statement * Update README.md * Create expect_column_set_to_be_unique_case_insensitive.sql (#138) * Create expect_column_set_to_be_unique_case_insensitive.sql * adjusting consistent casing test and documentation * adjusting formatting and adding integration test * Fix formatting * Formatting updates * adjusting Readme and adding test instance * Fix spelling Co-authored-by: clausherther <claus@calogica.com> * Change check for data date out of range to use timestamp (#145) * Update CHANGELOG.md * Update CHANGELOG.md * Update CHANGELOG.md * Added partition by in lag tests (#146) * Added partition by parameter * Added documentation * Modified the test to accept list instead of string * created data and implemented tests * corrected test in yml * Update formatting, test data and test macro Co-authored-by: clausherther <claus@calogica.com> * Update CHANGELOG.md * Update CHANGELOG.md * Fix emails.sql (#153) * Adds test for column presence (#149) * add test for column not to exist * Update expect_table_columns_not_to_contain_set.sql * Update README.md * name change and inner joined * update readme * update test * Fix expect_row_values_to_have_recent_data issues on bigquery (#147) * Add datetime and timestamp test columns * Convert all evals to timestamps * Add datatypes * Update schema tests * Update CHANGELOG.md * Update README.md * Add pre-commit config (#156) * Add github actions workflow (#159) * Add github workflow * Remove pre-commit * Add .circleci/config.yml (#161) * Add .circleci/config.yml * Remove github action * Update postgres test * Add dbt install * Add env variables * Install dbt dependencies * Empty postgres password * Upgrade postgres image * Update connection settings * Fix postgres profile * Move profiles * Add BigQuery run * Fix job name * Update key path * Update config * Update schema * Add Snowflake tests * Update profile * Add back postgres * Show group_by columns in validation errors for column increasing test (#158) * Show group_by columns in validation errors for column increasing test * Add github actions workflow (#159) * Add github workflow * Remove pre-commit * Show group_by columns in validation errors for column increasing test * Add .circleci/config.yml (#161) * Add .circleci/config.yml * Remove github action * Update postgres test * Add dbt install * Add env variables * Install dbt dependencies * Empty postgres password * Upgrade postgres image * Update connection settings * Fix postgres profile * Move profiles * Add BigQuery run * Fix job name * Update key path * Update config * Update schema * Add Snowflake tests * Update profile * Add back postgres * Show group_by columns in validation errors for column increasing test * Jinja whitespace update (to force CI) Co-authored-by: Claus Herther <claus@calogica.com> * implement exclusion_condition (#1) * move exclusion_condition to closing statement * Update README.md * Add integration test Co-authored-by: agusfigueroa-htg <77272542+agusfigueroa-htg@users.noreply.github.com> Co-authored-by: clausherther <claus@calogica.com> Co-authored-by: Josh Jones <josh.jones@accenture.com> Co-authored-by: Lucas Larbodiere <62683844+Lucasthenoob@users.noreply.github.com> Co-authored-by: Randy Caddell <64412616+rcaddell@users.noreply.github.com> Co-authored-by: dluftspring <daniel.luftspring@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Not possible to put partition by parameters in the following tests:
Changes:
Please let me know if there is anything