Add option to escape raw strings in RegEx functions #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clausherther
changed the title
|
@adamcunnington-mlg would love your eyes on this when you get a chance. Thanks! |
clausherther
force-pushed
the
fix/issue-190-regex-matching
branch
from
e7d3f36
to
39f0b1f
Compare
clausherther
changed the title
I'm going to go ahead and merge this for the upcoming release, since it's a non-breaking change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #190
This PR adds functionality to allow the RegEx-based tests, such as
expect_column_values_to_match_regexto accept unescaped/raw string patterns, by adding an optionalis_rawparameter to the relevant tests. The default isFalse, i.e.regexstrings are not automatically escaped.For more context:
BigQuery: uses
r'...'to mark the string as "raw"Snowflake: uses
$$..$$to avoid needing escape characters (see https://docs.snowflake.com/en/sql-reference/functions-regexp.html#specifying-regular-expressions-in-dollar-quoted-string-constants)