Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add expect_column_distinct_count_to_be_less_than.sql #193

Merged
merged 4 commits into from
Sep 7, 2022

Conversation

dylanrigal
Copy link
Contributor

  • expect_column_distinct_count_to_be_less_than.sql is a copy of expect_column_distinct_count_to_be_greater_than.sql, but with "<" instead of ">"
  • README.md is updated to reflect addition

Copy of expect_column_distinct_count_to_be_greater_than.sql, but replace ">" with "<"
@clausherther
Copy link
Contributor

Hi @dylanrigal thanks for this PR! Could you also please add an integration test in integration_tests/models/schema_tests/schema.yml ? Let me know if you need help with that.

@dylanrigal
Copy link
Contributor Author

Hi @dylanrigal thanks for this PR! Could you also please add an integration test in integration_tests/models/schema_tests/schema.yml ? Let me know if you need help with that.

Hi Claus, thanks for reviewing. I just added an integration test in the specified location. Let me know if there is anything else to add.

@clausherther
Copy link
Contributor

@dylanrigal great, thanks! I also added a version with row_condition. I'll run the tests and will likely merge to main today. Not sure yet when I'll cut a new release though, but won't be that far off. Is this something you need in a release urgently?

@clausherther clausherther self-requested a review September 7, 2022 15:29
Copy link
Contributor

@clausherther clausherther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@clausherther clausherther merged commit 0ad4454 into calogica:main Sep 7, 2022
@dylanrigal
Copy link
Contributor Author

@clausherther Thanks for merging. No it isn't urgent, but looking forward to the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants