Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add duckdb support #271

Merged
merged 7 commits into from
Aug 6, 2023
Merged

Add duckdb support #271

merged 7 commits into from
Aug 6, 2023

Conversation

clausherther
Copy link
Contributor

Summary of Changes

This PR adds support for duckdb, including updates to integration tests and CI.

Why Do We Need These Changes

dbt-date recently added support for duckdb in conjunction with dbt metrics layer testing.

Reviewers

@jwills

@clausherther clausherther changed the title Add Duck db support Add duckdb support Aug 6, 2023
@clausherther clausherther marked this pull request as draft August 6, 2023 19:31
jwills
jwills approved these changes Aug 6, 2023
View reviewed changes
Copy link

@jwills jwills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM-- thank you so much @clausherther!

integration_tests/models/schema_tests/timeseries_hourly.sql Outdated Show resolved Hide resolved
@clausherther clausherther marked this pull request as ready for review August 6, 2023 22:45
@clausherther clausherther merged commit 276777f into main Aug 6, 2023
1 check passed
@clausherther clausherther deleted the duck-db-support branch August 6, 2023 22:47
@eivl eivl mentioned this pull request Aug 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwills jwills jwills approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clausherther @jwills