Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tox + GHA #319

Closed
wants to merge 1 commit into from
Closed

Add tox + GHA #319

wants to merge 1 commit into from

Conversation

jtcohen6
Copy link

Issue this PR Addresses/Closes

Closes #318

Summary of Changes

  • Add tox with Postgres as target (dbt_integration_postgres)
  • Add GitHub Action for running integration tests against Postgres via tox
  • [Nice to have] Add dev-requirements.txt to install tox and latest dbt-core + dbt-postgres for local development/testing
  • TODO: Set up integration tests for other adapters by adding to tox.ini + supported_adapters.env + GH workflow.
dbt_integration_postgres: commands[0] /Users/jerco/dev/product/packages/dbt-expectations/integration_tests> dbt deps --target postgres
15:00:17  Running with dbt=1.9.0-a1
15:00:17  Installing ../
15:00:17  Installed from <local @ ../>
15:00:17  Installing calogica/dbt_date
15:00:18  Installed from version 0.10.1
15:00:18  Up to date!
dbt_integration_postgres: commands[1] /Users/jerco/dev/product/packages/dbt-expectations/integration_tests> dbt build --target postgres
15:00:18  Running with dbt=1.9.0-a1
15:00:19  Registered adapter: postgres=1.9.0-a1
15:00:19  Unable to do partial parsing because saved manifest not found. Starting full parse.
15:00:20  Found 12 models, 157 data tests, 685 macros
15:00:20  
15:00:20  Concurrency: 5 threads (target='postgres')
...
15:00:22  Done. PASS=169 WARN=0 ERROR=0 SKIP=0 TOTAL=169
  dbt_integration_postgres: OK (5.22=setup[0.03]+cmd[1.43,3.76] seconds)
  congratulations :) (5.28 seconds)

Why Do We Need These Changes

As explained in #318, by setting up tox as a standard entry-point, the Core development team at dbt Labs can include dbt-expectations integration tests (along with other popular dbt packages) as part of our continuous development & delivery of dbt.

Reviewers

@clausherther


jobs:
run-tests:
uses: dbt-labs/dbt-package-testing/.github/workflows/run_tox.yml@main
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dbt-labs has tagged a commit for this workflow to ensure we don't accidentally break anyone during development.

Suggested change
uses: dbt-labs/dbt-package-testing/.github/workflows/run_tox.yml@main
uses: dbt-labs/dbt-package-testing/.github/workflows/run_tox.yml@v1

@clausherther
Copy link
Contributor

FYI, closing this since we'll be stopping support for this package by the end of year.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants