Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add aria-label attribute to input control #200

Merged
merged 2 commits into from
Jul 29, 2021
Merged

Add aria-label attribute to input control #200

merged 2 commits into from
Jul 29, 2021

Conversation

brianjgeiger
Copy link
Contributor

@brianjgeiger brianjgeiger commented Jul 26, 2021 •
edited
Loading

Purpose

Add the ability to specify an aria-label that will be attached to the text input field. This will fix #15

Changes

  1. Use HTML input field for the text input field instead of ember input helper
  2. Add ariaLabel parameter to the tag-input
  3. Use the ariaLabel parameter in the text input field
  4. Update README
  5. Update dummy app

@calvinlough calvinlough merged commit a8b103b into calvinlough:master Jul 29, 2021
@calvinlough
Copy link
Owner

@brianjgeiger Tagged and released as 2.0.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calvinlough calvinlough calvinlough left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Aria Labels
2 participants
@brianjgeiger @calvinlough