Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove initialization of wires #1080

Closed
Tracked by #1072
nathanielnrn opened this issue Jul 6, 2022 · 4 comments · Fixed by #1085
Closed
Tracked by #1072

Remove initialization of wires #1080

nathanielnrn opened this issue Jul 6, 2022 · 4 comments · Fixed by #1085

Comments

@nathanielnrn
Copy link
Contributor

No description provided.

@nathanielnrn
Copy link
Contributor Author

Not sure where this takes places, do you maybe know off the top of your head @rachitnigam?

@rachitnigam
Copy link
Contributor

If it's the verilog backend then here: https://github.com/cucapra/calyx/blob/master/src/backend/verilog.rs#L182

The --disable-init flag removes the initialize blocks. If you're talking about the axi backend then I'm not sure but it'll be axi.rs probably

@nathanielnrn
Copy link
Contributor Author

Quick question that came up while working on this: Should

module std_wire #(
  parameter WIDTH = 32
) (
  input wire logic [WIDTH - 1:0] in,
  output logic [WIDTH - 1:0] out
);
  assign out = in;
endmodule

in port be a wire or just a logic (do people say this? Feels more natural to say reg.) @andrewb1999 changes has this as just a logic. See changed versus original

@rachitnigam
Copy link
Contributor

Thats because we merged a change since then. You can look at the blame to see when that changed but I don't think you need to change anything here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants