-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Axi test harness #1153
Axi test harness #1153
Conversation
This commit succesfully writes the output of our computation kernel to an cocotbext-Axi AxiLiteRam.
We are now able to call runt and have coctb run simulations on correct data. However, currently cocotb does not perform the correct computation on all data, rather it will choose one kernel to use for all data. Additionally, there are some extraneous outputs in runt output.
fpga/test-harness/hdl/vadd/main.sv
Outdated
@@ -0,0 +1,771 @@ | |||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this file need to be committed? Seems like it is generated from Calyx
Looks like everything is passing @nathanielnrn! Merge when ready! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually I noticed there is a really big .sv
file we're committing. Is that intentional?
Latest commit makes the |
Neat! Hella weird about the newline nonsense. I guess I suspect some vagary about the test's shell pipeline… May I recommend using |
Usually we use |
Okay, my changes should fix the silly |
@nathanielnrn if you'd like, feel free to press the big green button! Congratulations on a successful summer research project! |
I'm not sure how, but it seems like these symlinks got rearranged into the wrong directories in #1153. The `compile/` and `emulate/` directories are just supposed to contain outputs, and the inputs are supposed to be in the main test directory.
* Clean up Xilinx tests I'm not sure how, but it seems like these symlinks got rearranged into the wrong directories in #1153. The `compile/` and `emulate/` directories are just supposed to contain outputs, and the inputs are supposed to be in the main test directory. * Fix XML generation Adapt to quick_xml >= 0.28.0. * Fix Xilinx Verilog compilation tests Put the expect files into their own proper directory, and point the Runt config at that. The `compile/` directory is supposed to be empty files, just marking the success of the Vivado execution. * Add empty placeholders for compile tests * Add tests for kernel.xml generation
Thought it would be useful to open a draft PR to allow time to get feedback while classes are starting and I'm less available. This is nearly done.
Pull request allows for runt testing of cocotb simulation which outputs the execution of a kernel based on
examples/dahlia
.data
and.expected
files.Also introduces a subdirectory specifically for cocotb tests.
DRAFT: Regarding the reason this is a draft. Currently, running the make commands from runt does not behave the same way as running each command from a single shell one by one. Specifically, the Makefile does not use a new
toplevel.v
in spite of the-B
flag. This means that a single computation (i.e dot-product) is performed on all data (i.e vectorized add data).Additionally, make outputs some text which is specific to the file system running the command. For example, make outputs the commands it performs. Is there a way to selectively gather this text within runt? Just adding some
tail
andhead
commands to our output in therust.toml
?