Simplify logic on static designs #1775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rachitnigam
reviewed
Nov 13, 2023
| // If they explicitly say "None" or "none", hten we set it to None. | ||
| // Makes things a bit confusing. | ||
| let cycle_limit = if cycle_limit_str.is_none() { | ||
| Some(33554432) |
There was a problem hiding this comment.
How is this number chosen?
There was a problem hiding this comment.
Ah my bad should've explained that.
I basically looked at what worked well for the LUT numbers for the polybench stuff I've been working on. 33554432=2^25 ended up working well as an upper bound.
There was a problem hiding this comment.
I think we need to be a little more principled about this perhaps. What happens for higher numbers? We want some argument for why a 25-bit counter being the maximum is a good default choice.
There was a problem hiding this comment.
Ok finally fixed this to default to none (i.e., no limit). We can always set cycle-limit though manually if we want.
|
Forgot to merge so doing it now. |
rachitnigam
pushed a commit
that referenced
this pull request
Feb 16, 2024
* command line cycle limit parse * clippy * better static guard simplification * rewrite test * small change * small change * rewrite test * default to none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Namely: